Messages in this thread | | | Subject | Re: [PATCH] char/moxa.c: fix endianess and multiple-card issues | From | Alan Cox <> | Date | Sun, 20 Aug 2006 19:28:48 +0100 |
| |
Ar Gwe, 2006-08-18 am 13:39 +0200, ysgrifennodd Dirk Eibach: > From: Dirk Eibach <eibach@gdsys.de> > > While testing Moxa C218T/PCI on PowerPC 405EP I found that loading > firmware using the linux kernel driver fails because calculation of the > checksum is not endianess independent in the original code.
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
Acked-by: Alan Cox <alan@redhat.com>
Checksum changes are clearly correct. Other changes is an improvement but not I think enough to handle malicious firmware attacks. That said such an attacker has CAP_SYS_RAWIO anyway so that part is irrelevant except for neatness
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |