Messages in this thread | | | Date | Fri, 18 Aug 2006 18:23:29 -0400 | From | "Ed L. Cashin" <> | Subject | Re: [PATCH 2.6.18-rc4] aoe [06/13]: clean up printks via macros |
| |
On Fri, Aug 18, 2006 at 09:29:45PM +0200, Arnd Bergmann wrote: > On Friday 18 August 2006 19:39, Ed L. Cashin wrote: > > > > +#define xprintk(L, fmt, arg...) printk(L "aoe: " "%s: " fmt, __func__, ## arg) > > +#define iprintk(fmt, arg...) xprintk(KERN_INFO, fmt, ## arg) > > +#define eprintk(fmt, arg...) xprintk(KERN_ERR, fmt, ## arg) > > +#define dprintk(fmt, arg...) xprintk(KERN_DEBUG, fmt, ## arg) > > + > > Can't you use the dev_{info,error,dbg}() functions instead?
That's a good thought, but I don't think so. The dev_* macros don't add the function name to the printed message, and we don't have a struct device pointer in all our contexts. Even if we did, it would be kind of forced to do that just to try to get the prefix "aoe: " and the function name into the printks, which the new macros do nicely.
-- Ed L Cashin <ecashin@coraid.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |