Messages in this thread | | | Date | Fri, 18 Aug 2006 17:41:26 +0200 | From | Thomas Klein <> | Subject | Re: [2.6.19 PATCH 4/7] ehea: ethtool interface |
| |
Hi Alexey,
first of all thanks a lot for the extensive review.
Alexey Dobriyan wrote: >> + u64 hret = H_HARDWARE; > > Useless assignment here and everywhere. >
Initializing returncodes to errorstate is a cheap way to prevent accidentally returning (uninitalized) success returncodes which can lead to catastrophic misbehaviour.
>> +static void netdev_get_drvinfo(struct net_device *dev, >> + struct ethtool_drvinfo *info) >> +{ >> + strncpy(info->driver, DRV_NAME, sizeof(info->driver) - 1); >> + strncpy(info->version, DRV_VERSION, sizeof(info->version) - 1); > > Use strlcpy() to not forget -1 accidently.
I agree.
Kind regards Thomas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |