Messages in this thread | | | Date | Fri, 18 Aug 2006 16:33:28 +0200 | From | Jörn Engel <> | Subject | Re: [2.6.19 PATCH 3/7] ehea: queue management |
| |
On Fri, 18 August 2006 15:25:11 +0200, Thomas Klein wrote: > Arjan van de Ven wrote: > >>+ queue->queue_length = nr_of_pages * pagesize; > >>+ queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *)); > > > > > >wow... is this really so large that it warrants a vmalloc()??? > > Agreed: Replaced with kmalloc()
kzalloc() and you can remove the memset() as well.
Jörn
-- Data dominates. If you've chosen the right data structures and organized things well, the algorithms will almost always be self-evident. Data structures, not algorithms, are central to programming. -- Rob Pike - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |