Messages in this thread | | | Date | Thu, 17 Aug 2006 10:45:14 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH 1/6] IP100A, add end of pci id table |
| |
Jesse Huang wrote: > @@ -212,7 +212,7 @@ static const struct pci_device_id sundan > { 0x1186, 0x1002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4 }, > { 0x13F0, 0x0201, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 5 }, > { 0x13F0, 0x0200, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 6 }, > - { } > + { 0,} > }; > MODULE_DEVICE_TABLE(pci, sundance_pci_tbl); > > @@ -231,7 +231,7 @@ static const struct pci_id_info pci_id_t > {"D-Link DL10050-based FAST Ethernet Adapter"}, > {"Sundance Technology Alta"}, > {"IC Plus Corporation IP100A FAST Ethernet Adapter"}, > - { } /* terminate list. */ > + { NULL,} /* terminate list. */
NAK.
An empty array element "{ }" implies NULL. It is the kernel standard to prefer "{ }" over an explicit initialization. Looks cleaner.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |