Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor | Date | Tue, 01 Aug 2006 20:30:17 -0600 |
| |
Andi Kleen <ak@suse.de> writes:
> "Eric W. Biederman" <ebiederm@xmission.com> writes: >> } >> @@ -200,6 +224,178 @@ static void putstr(const char *s) >> outb_p(0xff & (pos >> 1), vidport+1); >> } >> >> +static void vid_console_init(void) > > Please just use early_printk instead of reimplementing this. > I think it should work in this context too.
It doesn't or at least it didn't. I can look again though.
>> +static inline int tolower(int ch) >> +{ >> + return ch | 0x20; >> +} >> + >> +static inline int isdigit(int ch) >> +{ >> + return (ch >= '0') && (ch <= '9'); >> +} >> + >> +static inline int isxdigit(int ch) >> +{ >> + ch = tolower(ch); >> + return isdigit(ch) || ((ch >= 'a') && (ch <= 'f')); >> +} > > And please reuse the Linux code here.
Reuse is hard because we really are a separate executable, in a slightly different environment.
> Actually the best way to reuse would be to first do 64bit uncompressor > and linker directly, but short of that #includes would be fine too.
> Would be better to just pull in lib/string.c
Maybe. Size is fairly important here so I am concerned that I will pull in more than I need. But look and see if I can pull in just a subset of what is needed.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |