Messages in this thread | | | Date | Wed, 2 Aug 2006 08:09:54 +1000 | From | Herbert Xu <> | Subject | Re: [BLOCK] bh: Ensure bh fits within a page |
| |
On Tue, Aug 01, 2006 at 09:33:54PM +0200, Andi Kleen wrote: > > diff --git a/fs/buffer.c b/fs/buffer.c > > index 71649ef..b998f08 100644 > > --- a/fs/buffer.c > > +++ b/fs/buffer.c > > @@ -2790,6 +2790,7 @@ int submit_bh(int rw, struct buffer_head > > BUG_ON(!buffer_locked(bh)); > > BUG_ON(!buffer_mapped(bh)); > > BUG_ON(!bh->b_end_io); > > + WARN_ON(bh_offset(bh) + bh->b_size > PAGE_SIZE); > > What happens when someone implements direct large page IO?
Then they'll need to change submit_bh to generate more than one bvec. At that time they can remove this warning :)
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |