Messages in this thread | | | Date | Tue, 1 Aug 2006 18:34:21 +0400 | From | Evgeniy Polyakov <> | Subject | Re: [take2 1/4] kevent: core files. |
| |
On Tue, Aug 01, 2006 at 10:27:36AM -0400, James Morris (jmorris@namei.org) wrote: > > > > + u->ready_num = 0; > > > > +#ifdef CONFIG_KEVENT_USER_STAT > > > > + u->wait_num = u->im_num = u->total = 0; > > > > +#endif > > > > > > Generally, #ifdefs in the body of the kernel code are discouraged. Can > > > you abstract these out as static inlines? > > > > Yes, it is possible. > > I would ask is it needed at all? > > Yes, please, it is standard kernel development practice.
Will do. Thanks, James.
> -- > James Morris > <jmorris@namei.org>
-- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |