Messages in this thread | | | Date | Tue, 1 Aug 2006 14:29:43 +1000 | From | Paul Mackerras <> | Subject | Re: [PATCH] Missing failure handling |
| |
Panagiotis Issaris writes:
> - cardmap_set(&all_ppp_units, unit, ppp); > + ret = cardmap_set(&all_ppp_units, unit, ppp); > + if (ret != 0) { > + printk(KERN_ERR "PPP: couldn't set cardmap\n");
This is a pretty useless message, in that it will mean nothing to a user who sees it. It would be better to set ret = -ENOMEM and not print the message, I think.
Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |