lkml.org 
[lkml]   [2006]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Missing failure handling
Panagiotis Issaris writes:

> - cardmap_set(&all_ppp_units, unit, ppp);
> + ret = cardmap_set(&all_ppp_units, unit, ppp);
> + if (ret != 0) {
> + printk(KERN_ERR "PPP: couldn't set cardmap\n");

This is a pretty useless message, in that it will mean nothing to a
user who sees it. It would be better to set ret = -ENOMEM and not
print the message, I think.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-01 07:03    [W:0.034 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site