Messages in this thread | | | From | Andi Kleen <> | Subject | Re: 2.6.18-rc1-mm1 fails on amd64 (smp_call_function_single) | Date | Mon, 10 Jul 2006 04:25:07 +0200 |
| |
On Monday 10 July 2006 03:49, Chuck Ebbert wrote: > In-Reply-To: <20060709154445.60d6619c.akpm@osdl.org> > > On Sun, 9 Jul 2006 15:44:45 -0700, Andrew Morton wrote: > > > I meant, in smp.h: > > > > #else /* CONFIG_SMP */ > > #define smp_call_function_single(cpu, fn, arg, x, y) fn(arg) > > #endif /* CONFIG_SMP */ > > But smp_call_function_single() generates an error if you try to call > it on your own CPU, so that doesn't make sense.
I have a full patch to be mirrored out soon.
Your patch is still wrong because now it won't be initialized on the BP
> > I fixed it like this, because that register defaults to zero > anyway and doesn't need initialization on CPU 0. > > What I can't figure out is how this ever gets called on CPU 0 > during init, whether it's SMP or not.
The notifier is called from time.c
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |