lkml.org 
[lkml]   [2006]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] FDPIC: Add coredump capability for the ELF-FDPIC binfmt [try #3]
On Fri, 07 Jul 2006 10:54:36 +0100
David Howells <dhowells@redhat.com> wrote:

> Andrew Morton <akpm@osdl.org> wrote:
>
> > > +#define roundup(x, y) ((((x) + ((y) - 1)) / (y)) * (y))
> >
> > The GFS2 tree has
> >
> > ...
> > +#define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d))
>
> They aren't exactly equivalent.

OK.

I count 45 different implementations of this in the tree. Ho hum.

> In any case, we probably shouldn't be using divide, but should rather be using
> shifts since the divisors are powers of two. I wonder if the compiler will
> make the substitution...
>

It usually manages to. iirc, less successfully if signed quantities are
used.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-07 12:23    [W:0.352 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site