lkml.org 
[lkml]   [2006]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: fs/xfs/xfs_vnodeops.c:xfs_readdir(): NULL variable dereferenced
Date
> > <--  snip  -->
> >
> > Note that tp is never assigned any value other than NULL (and the
> > Coverity checker found a way how tp might be dereferenced four
> > function calls later).
>
> Then the bug is probably in the function call that uses tp
> without first checking whether it's null. Can you tell us
> where that dereference occurs?
>
> Cheers,
>
> Dave.

Maybe, but the above code is confusing too.

Why not get rid of tp and explicitly pass NULL as "xfs_dir_getdents(NULL, dp, uiop, eofp);"?

Hua

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-07 01:41    [W:0.280 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site