Messages in this thread | | | Date | Thu, 6 Jul 2006 09:28:05 -0700 (PDT) | From | Vadim Lobanov <> | Subject | Re: [PATCH] Fix poll() nfds check. |
| |
On Thu, 6 Jul 2006, Ulrich Drepper wrote:
> On 7/5/06, Andrew Morton <akpm@osdl.org> wrote: > > [EINVAL] > > The nfds argument is greater than {OPEN_MAX}, or ... > > This requirement must be treated the same way as the EMFILE error in > open(): ignore the OPEN_MAX limit if ulimit says so. The question is > what to do if the ulimit < OPEN_MAX. POSIX does not require OPEN_MAX > to be the exact limit.
This interpretation makes more sense to me. No hardcoded magic number limits where the behavior of the syscall changes.
> So, I think removing the OPEN_MAX comparison is the correct way to do > this here. If somebody wants strict POSIX compliance they have to set > ulimit -n to 256.
Andrew, assuming that you're willing to make this change to the code, I can redo this patch against the latest rc and resend, if that'll make it easier to apply.
-- Vadim Lobanov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |