Messages in this thread | | | Date | Tue, 01 Aug 2006 07:50:35 +0800 | From | "Antonino A. Daplas" <> | Subject | Re: [PATCH] crash in aty128_set_lcd_enable on PowerBook |
| |
Olaf Hering wrote: > On Sun, Jul 16, Olaf Hering wrote: > >> Current Linus tree crashes in aty128_set_lcd_enable() because par->pdev >> is NULL. This happens since at least a week. Call trace is: >> >> aty128_set_lcd_enable >> aty128fb_set_par >> fbcon_init >> visual_init >> take_over_console >> fbcon_takeover >> notifier_call_chain >> blocking_notifier_call_chain >> register_framebuffer >> aty128fb_probe >> pci_device_probe >> bus_for_each_dev >> driver_attach >> bus_add_driver >> driver_register >> __pci_register_driver >> aty128fb_init >> init >> kernel_thread >> > > > - info->fix was assigned twice. > - par->vram_size is assigned in aty128_probe(), no need to redo it again in aty128_init() > - register_framebuffer() uses uninitialized struct members, > move it past par->pdev assignment and past aty128_bl_init(). > >
Looks good.
> Signed-off-by: Olaf Hering <olh@suse.de> Acked-by: Antonino Daplas <adaplas@pol.net>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |