Messages in this thread | | | Date | Mon, 31 Jul 2006 15:46:22 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [linux-usb-devel] [PATCH] Properly unregister reboot notifier in case of failure in ehci hcd |
| |
On Mon, 31 Jul 2006, Aleksey Gorelov wrote:
> > What code duplication? Doing it the way I suggested doesn't require > > adding any new code at all. You, on the other hand, added several > > routines for bus glue that does virtually nothing. > > But you can not use exactly same shutdown function with both pci and platform glue. You need to > convert pci/platform device to hcd anyway, right ? So this will add 2 doing 'virtually nothing' > routines anyway (unless you just want to duplicate the code of shutdown routine for for platform > glue). For ohci, you would need to do the same, hence 2 more routines, 4 total. With bus glue, I > added just 2. Am I missing something here ?
Okay, now I understand your point. Yes, it makes sense to do it your way.
Alan Stern
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |