Messages in this thread | | | From | Herbert Xu <> | Subject | Re: [PATCH] Fix trivial unwind info bug | Date | Tue, 01 Aug 2006 00:52:32 +1000 |
| |
Markus Armbruster <armbru@redhat.com> wrote: > CFA needs to be adjusted upwards for push, and downwards for pop. > arch/i386/kernel/entry.S gets it wrong in one place. > > Signed-off-by: Markus Armbruster <armbru@redhat.com>
Thanks for the patch Markus. Andi Kleen is now maintaining i386 so please cc him in future for i386 patches.
> diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S > index d9a260f..37a7d2e 100644 > --- a/arch/i386/kernel/entry.S > +++ b/arch/i386/kernel/entry.S > @@ -204,7 +204,7 @@ #define RING0_PTREGS_FRAME \ > ENTRY(ret_from_fork) > CFI_STARTPROC > pushl %eax > - CFI_ADJUST_CFA_OFFSET -4 > + CFI_ADJUST_CFA_OFFSET 4 > call schedule_tail > GET_THREAD_INFO(%ebp) > popl %eax
I wonder if this is related to the problem of dump_stack() crashing...
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |