Messages in this thread | | | Subject | Re: [PATCH] ixgb: add PCI Error recovery callbacks | From | "Zhang, Yanmin" <> | Date | Mon, 03 Jul 2006 13:49:26 +0800 |
| |
On Fri, 2006-06-30 at 00:26, Linas Vepstas wrote: > Adds PCI Error recovery callbacks to the Intel 10-gigabit ethernet > ixgb device driver. Lightly tested, works. > > Signed-off-by: Linas Vepstas <linas@austin.ibm.com> > +/** > + * ixgb_io_error_detected() - called when PCI error is detected > + * @pdev pointer to pci device with error > + * @state pci channel state after error > + * > + * This callback is called by the PCI subsystem whenever > + * a PCI bus error is detected. > + */ > +static pci_ers_result_t ixgb_io_error_detected (struct pci_dev *pdev, > + enum pci_channel_state state) > +{ > + struct net_device *netdev = pci_get_drvdata(pdev); > + struct ixgb_adapter *adapter = netdev->priv; > + > + if(netif_running(netdev)) > + ixgb_down(adapter, TRUE); > + > + pci_disable_device(pdev); > + > + /* Request a slot reset. */ > + return PCI_ERS_RESULT_NEED_RESET; > +} Both pci_disable_device and ixgb_down would access the device. It doesn't follow Documentation/pci-error-recovery.txt that error_detected shouldn't do any access to the device. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |