Messages in this thread | | | Date | Fri, 21 Jul 2006 16:08:25 +0200 | From | Stefan Richter <> | Subject | Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc. |
| |
Pekka J Enberg wrote: > On Fri, 21 Jul 2006, Stefan Richter wrote: >> Contributors can't know what the (supposed) _agreements_ are. >> >> Contributors can only know what the _documented conventions_ are. > > Life gets easier when you accept the fact that there are different > conventions within the kernel, driven by maintainer preference. Which is > why it is impossible to document a definite set of conventions too. > CodingStyle really is just a good approximation [...]
What can a contributor do when he comes across code which deviates from CodingStyle? He cannot tell whether the initial developer wasn't forced to adhere to CodingStyle or the maintainer wants it that way. So, the contributor - could ask the maintainer for his ruleset before writing a patch, or - could simply write the patch and wait if the maintainer feels need to demand adjustments. I am not sure which strategy will consume less time of contributor and maintainer. -- Stefan Richter -=====-=-==- -=== =--== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |