lkml.org 
[lkml]   [2006]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH] revoke/frevoke system calls
On Thu, 20 Jul 2006 15:07:30 +0300 (EEST)
Pekka J Enberg <penberg@cs.Helsinki.FI> wrote:

> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> This patch implements the revoke(2) and frevoke(2) system calls for all
> types of files.
>
> ...
>
> - file = fget_light(fd, &fput_needed);
> + file = fget(fd);

This is sad.

> +static int revoke_files(struct task_struct *owner, struct inode *inode,
> + struct file *exclude, struct list_head *to_close)
> +{
> ...
> + spin_lock(&files->file_lock);
> ...
> + revoked = kmalloc(sizeof(*revoked), GFP_KERNEL);

This is bad.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-22 02:21    [W:0.052 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site