lkml.org 
[lkml]   [2006]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 01/33] Add apply_to_page_range() function
    On Tue, Jul 18, 2006 at 12:00:01AM -0700, Chris Wright wrote:
    >...
    > --- a/mm/memory.c Fri Mar 24 04:29:46 2006 +0000
    > +++ b/mm/memory.c Fri Mar 24 04:30:48 2006 +0000
    > @@ -1358,6 +1358,100 @@ int remap_pfn_range(struct vm_area_struc
    > }
    > EXPORT_SYMBOL(remap_pfn_range);
    >
    > +static inline int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,
    > + unsigned long addr, unsigned long end,
    > + pte_fn_t fn, void *data)
    >...
    > +static inline int apply_to_pmd_range(struct mm_struct *mm, pud_t *pud,
    > + unsigned long addr, unsigned long end,
    > + pte_fn_t fn, void *data)
    >...
    > +static inline int apply_to_pud_range(struct mm_struct *mm, pgd_t *pgd,
    > + unsigned long addr, unsigned long end,
    > + pte_fn_t fn, void *data)
    >...

    Please avoid "inline" in C files.

    (gcc already automatically inlines static functions with only one caller.)

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-18 12:43    [W:4.587 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site