Messages in this thread | | | Date | Tue, 18 Jul 2006 15:15:00 -0400 | From | Horms <> | Subject | Re: [PATCH] panic_on_oops: remove ssleep() |
| |
On Mon, Jul 17, 2006 at 09:22:17PM -0400, Chuck Ebbert wrote: > In-Reply-To: <31687.FP.7244@verge.net.au> > > On Mon, 17 Jul 2006 12:17:20 -0400, Horms wrote: > > > This patch is part of an effort to unify the panic_on_oops behaviour > > across all architectures that implement it. > > > > It was pointed out to me by Andi Kleen that if an oops has occured > > in interrupt context, then calling sleep() in the oops path will only cause > > a panic, and that it would be really better for it not to be in the path at > > all. > > i386 already checks in_interrupt() and panics immediately:
Very good point. I guess that needs to be moved to after panic_on_oops() if the change that Andi suggests works out.
-- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |