Messages in this thread | | | From | Sergei Organov <> | Subject | Re: [PATCH] Airprime driver improvements to allow full speed EvDO transfers | Date | Fri, 14 Jul 2006 14:13:59 +0400 |
| |
Greg KH <gregkh@suse.de> writes: > On Thu, Jul 13, 2006 at 10:20:19PM +0400, Sergei Organov wrote: [...] >> Besides, if the throttle() is that important and failure to handle it is >> a big mistake, why is it optional then? I mean why struct tty_operations >> with throttle field set to NULL is accepted in the first place? The same >> question is applicable to the struct usb_serial_driver. > > Yes, I didn't realize it was required.
That was my point, -- people don't realize it is dangerous not to handle throttle, and in fact it was not that dangerous before new tty buffering has been implemented. I do handle throttle in my driver, but it has been implemented as a part of work-around for the deficiencies of the old tty buffering. I seriously doubt I'd realize it's a must to honour throttle should I start to write the driver today.
-- Sergei. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |