Messages in this thread | | | Date | Fri, 14 Jul 2006 10:41:58 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] remove volatile from nmi.c |
| |
On Fri, 14 Jul 2006, Steven Rostedt wrote: > > > endflag = 1; > > smp_wmb(); > > This was what I originally wrote, and then I saw the set_wmb which made > me think that it was the proper way to do things (why else is it > there?). So if it shouldn't be used, then we should get rid of it or at > least mark it deprecated, otherwise you have people like me thinking > that we should use it.
Yeah, we should probably get rid of it. No need to even mark it deprecated, since nobody uses it anyway.
At a minimum, I think we should not document it in the locking documentation, making people incorrectly think it might be a good idea.
Hmm? Andrew?
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |