Messages in this thread | | | Date | Thu, 13 Jul 2006 02:38:29 -0700 | From | Andrew Morton <> | Subject | Re: please revert kthread from loop.c |
| |
On Wed, 12 Jul 2006 18:02:29 -0500 "Serge E. Hallyn" <serue@us.ibm.com> wrote:
> + if (lo->lo_state == Lo_rundown) { > + spin_unlock_irq(&lo->lo_lock); > + while (!kthread_should_stop());
eww.
A schedule_timeout_uninterruptible(1) or even cpu_relax() would be less sinful, but still unpleasant.
It's strange that the problem of kthread_stop(already_exitted_task) hasn't occurred before.
Again: why is this so hard? It shouldn't be. Perhaps because loop is using completions in bizarre ways where it should be using wake_up_process(), wait_event(), etc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |