Messages in this thread | | | Date | Tue, 11 Jul 2006 00:04:34 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] sysctl: Allow /proc/sys without sys_sysctl |
| |
On Tue, 11 Jul 2006 00:57:35 -0600 ebiederm@xmission.com (Eric W. Biederman) wrote:
> Andrew Morton <akpm@osdl.org> writes: > > > On Mon, 10 Jul 2006 16:38:59 -0600 > > ebiederm@xmission.com (Eric W. Biederman) wrote: > > > >> Since sys_sysctl is deprecated start allow it to be compiled out. > > > > This could be a tough one to get rid of (looks at sys_bdflush() again). > > > > I'd suggest we put a sys_bdflush()-style warning in there, see what that > > flushes out. > > Sounds sane. I know I have booted several kernels with it compiled out > but just because you can do without it doesn't mean that something > isn't using it. > > Hmm. The question is where do I want the put the warning message? > > When the code is compiled out? > When the code is compiled in?
Both. We want to find out who is using it.
> Probably both places at this point, and using the rate limited printk > I think instead of just the 5 printks that sys_bdflush uses...
No, I think five is enough. If something's using sys_sysctl() then it might be using it a lot - there's no point in irritating people over it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |