Messages in this thread | | | Date | Tue, 11 Jul 2006 00:16:40 +0200 | From | "Jesper Juhl" <> | Subject | Re: [RFC][PATCH 2/9] -Wshadow: Fix warnings in mconf |
| |
On 10/07/06, Martin Waitz <tali@admingilde.org> wrote: > hoi :) > > On Mon, Jul 10, 2006 at 01:12:37PM +0200, Jesper Juhl wrote: > > --- linux-2.6.18-rc1-orig/scripts/kconfig/mconf.c 2006-06-18 03:49:35.000000000 +0200 > > +++ linux-2.6.18-rc1/scripts/kconfig/mconf.c 2006-07-09 19:48:05.000000000 +0200 > > @@ -276,7 +276,7 @@ static void conf_save(void); > > static void show_textbox(const char *title, const char *text, int r, int c); > > static void show_helptext(const char *title, const char *text); > > static void show_help(struct menu *menu); > > -static void show_file(const char *filename, const char *title, int r, int c); > > +static void show_file(const char *fname, const char *title, int r, int c); > > > > static void cprint_init(void); > > static int cprint1(const char *fmt, ...); > > perhaps its more clear if you change the global variable instead? > perhaps to config_filename? >
Not a bad suggestion. Thanks.
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |