lkml.org 
[lkml]   [2006]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 7/8] FDPIC: Add coredump capability for the ELF-FDPIC binfmt [try #4]
Date
Oleg Nesterov <oleg@tv-sign.ru> wrote:

> Do you see any reason for tasklist_lock here (and in elf_core_dump) ?
>
> do_each_thread() is rcu-safe, and all tasks which use this ->mm must
> sleep in wait_for_completion(&mm->core_done) at this point.

Hmmm... do_each_thread() does not call rcu_read_lock/unlock(), but you may
well be right. What about kernel threads running on another CPU with
active_mm set to this mm (assuming I'm remembering correctly how that works)?
I'm not sure they'd be a problem, though.

It does sound like you've got a valid point, though.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-10 15:35    [W:0.031 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site