Messages in this thread | | | Date | Sat, 27 May 2006 21:20:27 +0100 | From | "Catalin Marinas" <> | Subject | Re: [PATCH 2.6.17-rc5 1/7] Base support for kmemleak |
| |
Hi Anne,
On 27/05/06, Anne Thrax <foobarfoobarfoobar@gmail.com> wrote: > mm/memleak.c: In function `insert_pointer': > mm/memleak.c:216: warning: unused variable `i' > mm/memleak.c: At top level: > mm/memleak.c:586: warning: 'memleak_scan' defined but not used [...] > If I'm not mistaken, you don't use 'i' outside of #ifdef CONFIG_FRAME_POINTER code.
Yes, indeed, I should've added "i" inside the CONFIG_FRAME_POINTER block.
> > +/* Scan the memory and print the orphan pointers */ > > +static void memleak_scan(void) > > I don't think this is used anywhere in memleak.c besides > #ifdef CONFIG_DEBUG_FS code.
I'm actually thinking about removing the conditional compilation on DEBUG_FS and just mandate this option. At the moment there is no other way to find the memory leaks apart from /sys/kernel/debug/memleak. The other option would be to scan the memory periodically from a timer or kernel thread and print the findings.
Thanks.
-- Catalin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |