Messages in this thread | | | Date | Fri, 26 May 2006 04:56:00 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH/2.6.17-rc4 10/10] bugs fix for marvell SATA on powerp c pl atform |
| |
Sven Luther wrote: > On Thu, May 18, 2006 at 04:50:46PM -0400, Mark Lord wrote: >> Jeff Garzik wrote: >>> Benjamin Herrenschmidt wrote: >>>> On Thu, 2006-05-18 at 12:03 +0800, Zang Roy-r61911 wrote: >> .. >>>>> @@ -1567,13 +1570,18 @@ static void mv5_read_preamp(struct mv_ho >>>>> static void mv5_enable_leds(struct mv_host_priv *hpriv, void __iomem >>>> *mmio) >>>>> { >>>>> u32 tmp; >>>>> - >>>>> +#ifndef CONFIG_PPC >>>>> writel(0, mmio + MV_GPIO_PORT_CTL); >>>>> +#endif >>>> You'll have to do better here too... I don't wee why when compiled on >>>> PPC, this driver should "magically" not clear those bits... At the very >>>> least, you should test the machine type if you want to do something >>>> specific to your platform, but first, you'll have to convince Jeff why >>>> this change has to be done in the first place and if there is a better >>>> way to handle it. >>> Correct... it does seem some bugs were found, but #ifdef powerpc is >>> certainly out of the question. We want the driver to work without >>> ifdefs on all platforms. >> Yup. I have a powerpc platform here with PCI-X, and a PCI-X Marvell card >> to try in it. So I'll pick up these changes and try to integrate them a >> little more nicely in my internal updated driver, and then pass it on to Jeff. > > Hi, ... > > I am trying to use a Marvell 88SX5081 based card here in my pegasos machine, > and i never got it working with the libata driver, even with the patches Zang > provided (and 2.6.16 though, maybe i should update to a newer version). The > marvell provided driver worked though at some time. > > Would it be possible to have access to your work, in order to not duplicate > effort or something ?
Do you have any debug output (see top of libata.h)?
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |