Messages in this thread | | | Date | Thu, 25 May 2006 20:15:24 -0400 | From | Florin Malita <> | Subject | Re: [PATCH] irda: missing allocation result check in irlap_change_speed() |
| |
David Miller wrote: > If the allocation fails we should probably do something > more interesting here, such as schedule a timer to try > again later. Otherwise the speed change will silently > never occur. > I thought the speed change would be piggybacked on the next frame, same as when 'now' == 0. Is that not the case?
self->speed = speed;
/* Change speed now, or just piggyback speed on frames */ if (now) { /* Send down empty frame to trigger speed change */ skb = dev_alloc_skb(0); if (skb) irlap_queue_xmit(self, skb); }
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |