Messages in this thread | | | Date | Thu, 25 May 2006 10:03:32 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [PATCH 1/3] mm: tracking shared dirty pages |
| |
On Thu, 25 May 2006, Peter Zijlstra wrote:
> On Thu, 2006-05-25 at 09:21 -0700, Christoph Lameter wrote: > > On Thu, 25 May 2006, Peter Zijlstra wrote: > > > > > @@ -1446,12 +1447,13 @@ static int do_wp_page(struct mm_struct * > > > > > > - if (unlikely(vma->vm_flags & VM_SHARED)) { > > > + if (vma->vm_flags & VM_SHARED) { > > > > You add this unlikely later again it seems. Why remove in the first place? > > I'm not sure I follow you, are you suggesting that we'll find the > condition to be unlikely still, even with most of the shared mappings > trapping this branch?
No, I just saw the opposite in a later patch. It was the -1 patch that does
+ if (unlikely(vma->vm_flags & VM_SHARED)) {
but thats a different context? \ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |