Messages in this thread | | | Date | Sun, 21 May 2006 15:21:03 -0400 (EDT) | From | Ameer Armaly <> | Subject | Re: [patch] initialize variables in fs/isofs/namei.c |
| |
On Sun, 21 May 2006, Dave Jones wrote:
> On Sun, May 21, 2006 at 03:02:34PM -0400, Ameer Armaly wrote: > > This patch removes un-initialized variable warnings for block and offset in > > namei.c, which are later initialized through a call to isofs_find_entry(). > > Which indicates the problem lies with gcc, just like with the other patches > 'fixing' these warnings. > I agree. The compiler should be smart enough to at least consider the possibility of initializing through pointers. > The warning is bogus. > It is, but at the same it's clutter; in my opinion, readability is not impacted by explicitly initializing variables that get initialized through a pointer, and we reduce annoying make output. > Dave > > -- > http://www.codemonkey.org.uk > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |