Messages in this thread | | | Date | Tue, 16 May 2006 11:04:40 +0200 | From | Takashi Iwai <> | Subject | Re: 2.6.17-rc4-mm1 |
| |
At Mon, 15 May 2006 11:11:11 -0700, Andrew Morton wrote: > > Takashi Iwai <tiwai@suse.de> wrote: > > > > -unsigned int snd_cards_lock = 0; /* locked for registering/using */ > > +static unsigned int snd_cards_lock = 0; /* locked for registering/using */ > > May as well remove the `= 0' while you're there. It adds four bytes to the > module unnecessarily.
Yep. Will remove it.
> > void snd_request_card(int card) > > { > > - int locked; > > - > > if (! current->fs->root) > > return; > > I wonder what that's there for.
This is almost for backward compatibility only. We have already module aliases, so it can be cleaned up.
Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |