lkml.org 
[lkml]   [2006]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.17-rc4-mm1
At Mon, 15 May 2006 11:11:11 -0700,
Andrew Morton wrote:
>
> Takashi Iwai <tiwai@suse.de> wrote:
> >
> > -unsigned int snd_cards_lock = 0; /* locked for registering/using */
> > +static unsigned int snd_cards_lock = 0; /* locked for registering/using */
>
> May as well remove the `= 0' while you're there. It adds four bytes to the
> module unnecessarily.

Yep. Will remove it.

> > void snd_request_card(int card)
> > {
> > - int locked;
> > -
> > if (! current->fs->root)
> > return;
>
> I wonder what that's there for.

This is almost for backward compatibility only.
We have already module aliases, so it can be cleaned up.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-16 11:07    [W:0.105 / U:1.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site