lkml.org 
[lkml]   [2006]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: PATCH: Fix broken PIO with libata
    Tejun Heo wrote:
    > Alan Cox wrote:
    >> #2 The core sets ATA_DFLAG_PIO to indicate PIO commands should be used
    >> on this channel. This same information is available in dev->dma_mode but
    >> for some reason we get two sources of the info. The ATA_DFLAG_PIO is set
    >> once during setup and then cleared but not re-computed by the revalidate
    >> function. This causes DMA commands to be issued when PIO would be and
    >> usually an Oops or hang
    >
    > Hmmm... I tried to fix this problem in the following commit. With it,
    > ATA_DFLAG_PIO isn't cleared over ata_dev_configure(). Only
    > ata_dev_set_mode() is allowed to diddle with it and does about the same
    > thing as your patch does.

    I presume he's looking at what users will hit when 2.6.17 is released...

    Jeff



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-16 19:13    [W:3.561 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site