Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH 3/3] reliable stack trace support (i386) | Date | Tue, 16 May 2006 17:15:11 +0200 |
| |
On Tuesday 16 May 2006 16:22, Jan Beulich wrote: > These are the i386-specific pieces to enable reliable stack traces. This is > going to be even more useful once CFI annotations get added to he assembly > code, namely to entry.S (a patch for that had been submitted several times).
Yes we should merge that. Can you resend it please?
> +static asmlinkage void show_trace_unwind(struct unwind_frame_info *info, void *log_lvl)
static asmlinkage ?
> +#define UNW_PC(frame) (frame)->regs.eip > +#define UNW_SP(frame) (frame)->regs.esp > +#ifdef CONFIG_FRAME_POINTER > +#define UNW_FP(frame) (frame)->regs.ebp > +#define FRAME_RETADDR_OFFSET 4 > +#define FRAME_LINK_OFFSET 0 > +#define STACK_BOTTOM(tsk) (((tsk)->thread.esp0 - 1) & ~(THREAD_SIZE - 1)) > +#define STACK_TOP(tsk) ((tsk)->thread.esp0) > +#endif
Same comments as for x86-64
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |