Messages in this thread | | | Subject | RE: Regression seen for patch "sched:dont decrease idle sleep avg" | From | Mike Galbraith <> | Date | Tue, 16 May 2006 06:07:10 +0200 |
| |
On Mon, 2006-05-15 at 12:01 -0700, Chen, Kenneth W wrote:
> [patch] sched: update comments in priority calculation w.r.t. implementation. > > Signed-off-by: Ken Chen <kenneth.w.chen@intel.com> > > --- ./kernel/sched.c.orig 2006-05-15 12:24:02.000000000 -0700 > +++ ./kernel/sched.c 2006-05-15 12:37:16.000000000 -0700 > @@ -746,10 +746,12 @@ static int recalc_task_prio(task_t *p, u > if (likely(sleep_time > 0)) { > /* > * User tasks that sleep a long time are categorised as > - * idle. They will only have their sleep_avg increased to a > - * level that makes them just interactive priority to stay > - * active yet prevent them suddenly becoming cpu hogs and > - * starving other processes. > + * idle. If they sleep longer than INTERACTIVE_SLEEP, it > + * will have its priority boosted to minimum MAX_BONUS-1. > + * For short sleep, they will only have their sleep_avg > + * increased to a level that makes them just interactive > + * priority to stay active yet prevent them suddenly becoming > + * cpu hogs and starving other processes. > */ > if (p->mm && sleep_time > INTERACTIVE_SLEEP(p)) { > unsigned long ceiling;
This comment still doesn't reflect what the code does. Please just delete the last four lines, they are incorrect.
-Mike
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |