Messages in this thread | | | Date | Mon, 15 May 2006 10:39:18 +0200 | From | Takashi Iwai <> | Subject | Re: [Alsa-devel] [PATCH] Fix a memory leak in pdaudiocf |
| |
At Sat, 13 May 2006 23:44:25 +0200, Jesper Juhl wrote: > > There's a potential memory leak in > sound/pcmcia/pdaudiocf/pdaudiocf.c::pdacf_config() > > If we leave via one of the *failed: labels we may leak 'parse', so add a > kfree(parse) to the end of the function and also make sure to set 'parse' > to NULL after the kfree() call a little further up so we don't do a > double-free of the pointer if we hit one of the *failed: labels after the > first kfree(). > > Since I don't have the hardware I can't test the patch beyond making sure > it compiles cleanly, but I feel pretty confident that it is correct. > > Please consider for inclusion.
This bug was already fixed in a different way on ALSA HG repo.
thanks,
Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |