| Subject | Re: [PATCH 41 of 53] ipath - disable interrupts while holding spinlock in RWQE get | From | Roland Dreier <> | Date | Mon, 15 May 2006 08:55:37 -0700 |
| |
> @@ -171,12 +171,13 @@ int ipath_get_rwqe(struct ipath_qp *qp, > n = rq->head - rq->tail; > if (n < srq->limit) { > srq->limit = 0; > - spin_unlock(&rq->lock); > + spin_unlock_irqrestore(&rq->lock, flags); > ev.device = qp->ibqp.device; > ev.element.srq = qp->ibqp.srq; > ev.event = IB_EVENT_SRQ_LIMIT_REACHED; > srq->ibsrq.event_handler(&ev, > srq->ibsrq.srq_context); > + spin_lock_irqsave(&rq->lock, flags);
ipath_get_rwqe() in the kernel now doesn't even have a flags variable. So this looks like a bug introduced earlier in this patch series. Please roll the fix up into the place where you added the bug.
- R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|