lkml.org 
[lkml]   [2006]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 24/35] Add support for Xen event channels.
Date

On 13 May 2006, at 13:27, Andrew Morton wrote:

>
>> + init_evtchn_cpu_bindings();
>> +
>> + /* No VIRQ or IPI bindings. */
>> + for (cpu = 0; cpu < NR_CPUS; cpu++) {
>
> Using NR_CPUS is a little... old-fashioned. I'd suggest a sweep
> through
> all the Xen code, look for places where it should be using
> for_each_foo_cpu().

Actually that's a particularly good catch in this case, since we use
per_cpu() inside the loop and that's only well defined for
cpu_possible_map. Oops.

The elusive users of ring.h are our split device drivers. It hides a
bunch of details about muxing requests and responses on the same ring,
and notification thresholds. There are a few other places we have ring
buffers but they are sufficiently simple that implementing in place is
clearer.

Thanks,
Keir

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-13 15:09    [W:0.157 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site