Messages in this thread | | | Date | Sat, 13 May 2006 02:04:34 +0200 | From | Carl-Daniel Hailfinger <> | Subject | Re: [patch] smbus unhiding kills thermal management |
| |
Zwane Mwaikambo wrote: > On Fri, 12 May 2006, Carl-Daniel Hailfinger wrote: > >> Pavel Machek wrote: >>> Do not enable the SMBus device on Asus boards if suspend >>> is used. We do not reenable the device on resume, leading to all sorts >>> of undesirable effects, the worst being a total fan failure after >>> resume on Samsung P35 laptop. >>> >>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> >>> Signed-off-by: Pavel Machek <pavel@suse.cz> >> This is probably also -stable material. > > Isn't it inevitable that we're going to have to rerun quirks on resume on > some hardware?
Yes, but until we have a proper infrastructure for that, we have to disable the smbus unhiding as a safe fix.
If you have the time to whip up a patch to add a sane quirks-on-resume infrastructure, I'd be grateful. See the thread "[RFC] [PATCH] Execute PCI quirks on resume from suspend-to-RAM" for some ugly proof-of-concept. My main motivation was to prevent bricking my laptop. Added functionality is desirable, but secondary.
Regards, Carl-Daniel -- http://www.hailfinger.org/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |