lkml.org 
[lkml]   [2006]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] Vectorize aio_read/aio_write methods
On Thu, May 11, 2006 at 03:50:03PM -0700, Badari Pulavarty wrote:
> diff -Naurp -X /usr/src/dontdiff linux-2.6.17-rc3/fs/smbfs/file.c linux-2.6.17-rc3.save/fs/smbfs/file.c
> --- linux-2.6.17-rc3/fs/smbfs/file.c 2006-04-26 19:19:25.000000000 -0700
> +++ linux-2.6.17-rc3.save/fs/smbfs/file.c 2006-05-09 15:30:32.000000000 -0700
> @@ -233,7 +233,7 @@ smb_file_read(struct file * file, char _
> (long)dentry->d_inode->i_size,
> dentry->d_inode->i_flags, dentry->d_inode->i_atime);
>
> - status = generic_file_read(file, buf, count, ppos);
> + status = do_sync_read(file, buf, count, ppos);
> out:
> return status;
> }

this look wrong. The additional work in smb_file_read/smb_file_write
needs to be done in smb_file_aio_read/smb_file_aio_write, and .read/.write
can be set to do_sync_read/do_sync_write directly.

> diff -Naurp -X /usr/src/dontdiff linux-2.6.17-rc3/fs/udf/file.c linux-2.6.17-rc3.save/fs/udf/file.c
> --- linux-2.6.17-rc3/fs/udf/file.c 2006-04-26 19:19:25.000000000 -0700
> +++ linux-2.6.17-rc3.save/fs/udf/file.c 2006-05-09 15:27:28.000000000 -0700
> @@ -136,7 +136,7 @@ static ssize_t udf_file_write(struct fil
> }
> }
>
> - retval = generic_file_write(file, buf, count, ppos);
> + retval = do_sync_write(file, buf, count, ppos);

ditto. also IIRC this only happens for the udf write path.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-12 09:41    [W:0.220 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site