Messages in this thread | | | Date | Thu, 11 May 2006 21:23:52 +0200 | From | Francois Romieu <> | Subject | Re: [PATCH] dl2k: use explicit DMA_48BIT_MASK |
| |
Jon Mason <jdmason@us.ibm.com> : [...] > DMA_*BIT_MASK is intended to be used in the DMA_API's checking of > DMA controller's addressable memory, where as this is masking off the > lower 48bits of a descriptor for its DMA address.
Imho it's the specific reason why the DMA_*BIT_MASK applies here: the code is already in dma-"tainted" land.
> I think a better solution (which I should've done when I pushed the > original patch) would be a driver specific #define.
$ find drivers -type f | xargs grep -i [^f]ffffffffffff[^f] | wc -l 12
No disagreement: it does not have a huge potential for code duplication.
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |