Messages in this thread | | | Date | Thu, 11 May 2006 17:55:37 +0200 | From | Jörn Engel <> | Subject | Re: fix compiler warning in ip_nat_standalone.c |
| |
On Thu, 11 May 2006 17:29:48 +0200, Rik Bobbaers wrote: > > i just made small patch that fixes a compiler warning:
Just in case Al didn't make it clear enough in the recent thread:
You cannot fix a compiler warning!
Either the code is wrong or it is right. A compiler warning can indicate that code is wrong, or it is a false positive. If the code is wrong, fix the _code_. If it isn't, ignore the warning or fix the _compiler_.
That said, your patch looks as if it would actually fix the code. I'm not firm enough with NAT to confirm that, though. So if it fixes the code, please state exactly that.
Jörn
-- Anything that can go wrong, will. -- Finagle's Law - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |