Messages in this thread | | | Subject | Re: [RFC][PATCH 1/5] uts namespaces: Implement utsname namespaces | From | (Eric W. Biederman) | Date | Sun, 09 Apr 2006 13:08:36 -0600 |
| |
Andi Kleen <ak@suse.de> writes:
> On Saturday 08 April 2006 22:28, Serge E. Hallyn wrote: > >> The consensus so far has been to start putting things into task_struct >> and move if needed. At least the performance numbers show that so far >> there is no impact. > > Performance is not the only consider consideration here. Overall > memory consumption is important too. > > Sure for a single namespace like utsname it won't make much difference, > but it likely will if you have 10-20 of these things.
The highest estimate I have seen is 10, including the current mount namespace.
Basically it looks like: mounts, uts, sysvipc, net, pid, uid. Not very many.
Even in your worst cast estimate of 20. That puts us at. 8*20 = 160. 160 vs 10K. or about a 1% size increase. Not terribly noticeable.
And I think 20 - 40 bytes of increase not 160 is a lot closer to where we will be in the short term.
>> iirc container patches have been sent before. Should those be resent, >> then, and perhaps this patchset rebased on those? > > I think so.
That is premature optimization, and it ties the implementations together. Which makes implementing this that much harder, and we do want separate sharing of these things.
Once we have something working I don't have a problem going back and revisiting what it takes to optimize the size of the implementation. But while we still have correctness issues to worry about such a small optimization before we can even measure the benefit or have a good feel of the users does not make sense.
If you really think this is a beneficial approach to reducing size you can already apply it to all of the thread pointers. Where the gain is immediately noticeable, and the count is similar.
We will be happy to follow the best current practices.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |