Messages in this thread | | | Date | Tue, 4 Apr 2006 02:47:15 -0700 | From | Andrew Morton <> | Subject | Re: [patch 2/3] mm: speculative get_page |
| |
Nick Piggin <npiggin@suse.de> wrote: > > +static inline struct page *page_cache_get_speculative(struct page **pagep)
Seems rather large to inline.
> +{ > + struct page *page; > + > + VM_BUG_ON(in_interrupt()); > + > +#ifndef CONFIG_SMP > + page = *pagep; > + if (unlikely(!page)) > + return NULL; > + > + VM_BUG_ON(!in_atomic());
This will go blam if !CONFIG_PREEMPT. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |