Messages in this thread | | | Date | Sat, 29 Apr 2006 18:00:11 +1000 | From | Paul Mackerras <> | Subject | Re: [PATCH]: powerpc/pseries: Print PCI slot location code on failure |
| |
Linas Vepstas writes:
> + location = (char *) get_property(event->dn, "ibm,loc-code", NULL); > + printk(KERN_ERR "EEH: Error: Cannot find partition endpoint " > + "for location=%s pci addr=%s\n", > + location, pci_name(event->dev));
If location is NULL, printk will fortunately save us from a null pointer dereference; still, it might be nice to have the message say "location=unknown" or something rather than "location=<NULL>".
Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |