Messages in this thread | | | Subject | Re: [PATCH] drivers/scsi/sd.c: fix uninitialized variable in handling medium errors | From | James Bottomley <> | Date | Wed, 26 Apr 2006 18:18:16 -0500 |
| |
On Wed, 2006-04-26 at 19:04 -0400, Mark Lord wrote: > Yes, but the difficulty there is that all of the convoluted logic > seems to still be wanted to set a correct "block_sectors" value, > needed as a parameter on the final call: > > scsi_io_completion(SCpnt, good_bytes, block_sectors << 9);
Erm, but that's only used for volume overflow (or other single sector errors), which this isn't ... Actually, as far as I can tell, the whole block_sectors calculation can be killed as well.
> >How does this work? > ... > > Looks potentially buggy (still).
Where?
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |