Messages in this thread | | | From | Keir Fraser <> | Subject | Re: [PATCH] i386: PAE entries must have their low word cleared first | Date | Wed, 26 Apr 2006 17:12:44 +0100 |
| |
On 26 Apr 2006, at 16:57, Hugh Dickins wrote:
>> Proposed fix for ptep_get_and_clear_full PAE bug. Pte_clear had the >> same >> bug, so use the same fix for both. > > You need to expand that comment with text from Jan & Keir's patch: > Andrew will want to know just what this bug was. The patch looks > good to me, except for the unnecessary do { } while (0) in the > definition of pte_clear: ah, you're only copying what was already > there, can't blame you for that, let's not worry about it.
I agree: the patch comment is rather brief, but the patch itself looks good. I suppose switching PAE's set_pte() from smp_wmb() to wmb() would logically belong in a separate patch.
-- Keir
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |