Messages in this thread | | | Subject | Re: [PATCH/RFC] s390: Hypervisor File System | From | Pekka Enberg <> | Date | Tue, 25 Apr 2006 09:58:24 +0300 |
| |
On Mon, 2006-04-24 at 19:19 +0200, Michael Holzheu wrote: > +#ifndef __HAVE_ARCH_STRRTRIM > +/** > + * strrtrim - Remove trailing characters specified in @reject > + * @s: The string to be searched > + * @reject: The string of letters to avoid > + */ > +void strrtrim(char *s, const char *reject)
I think this should return s to be consistent with other string API functions.
> +{ > + char *p; > + const char *r;
You need to exit here if strlen(s) is zero.
> + > + for (p = s + strlen(s) - 1; s <= p; p--) { > + for (r = reject; (*r != '\0') && (*p != *r); r++) > + /* nothing */;
Please use strchr for the above.
> + if (*r == '\0') > + break;
What are you testing here?
> + } > + *(p + 1) = '\0'; > +} > +EXPORT_SYMBOL(strrtrim); > +#endif
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |