Messages in this thread | | | Subject | Re: [PATCH 3/3] Assert notifier_block and notifier_call are not in init section | From | Chandra Seetharaman <> | Date | Tue, 25 Apr 2006 12:01:03 -0700 |
| |
On Mon, 2006-04-24 at 19:47 -0700, Linus Torvalds wrote: > > On Mon, 24 Apr 2006, sekharan@us.ibm.com wrote: > > > > Feel free to drop this patch if you think it is not needed. > > It's incorrect. > > The init section will be free'd, and as a result can be re-allocated to > other uses. Thus testing that data is not in the init-section makes no > sense. > > Testing for _code_ not being in the init section can be sensible, since > code never gets re-allocated (modulo module code, but that's never in the > init section). So checking the "notifier_call" part may be sensible, but > checking the notifier block data pointer definitely is not.
Two questions: 1) related to this patch: Do you want me to generate a patch that asserts only notifier calls ?
2) Unrelated to this patch: If the _code_ section is never reallocated or reused, what is the purpose of putting _code_ in the init section ? Only to make sure that the init calls are called in order ?
Thanks
chandra PS: I fixed my mailer to put my name. sorry about that.
> > Patches 1-2 applied. > > Linus --
---------------------------------------------------------------------- Chandra Seetharaman | Be careful what you choose.... - sekharan@us.ibm.com | .......you may get it. ----------------------------------------------------------------------
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |